-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac Mojave and Python 3.8 working branch #108
Comments
@eddo888 Wow! Super cool! I'd love to see it. Can you make a PR from your branch/fork? Thanks! |
Thanks
I tried to create a pull request from the forked repo on my mac.
I get this error, prepared to admin I’m not much good at creating a pull request,
any suggestions, I looked at the help and used source tree from atlassian to create the pull request,.
git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags --set-upstream origin refs/heads/python3.8_mac_mojave:refs/heads/python3.8_mac_mojave
Pushing to git@github.com:realpython/materials.git
ERROR: Permission to realpython/materials.git denied to eddo888.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Completed with errors, see above
… On 23 Apr 2020, at 10:53 am, Jim Anderson ***@***.***> wrote:
@eddo888 <https://github.com/eddo888> Wow! Super cool! I'd love to see it. Can you make a PR from your branch/fork?
Thanks!
jima
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAT5IL52KD4IV4NOYED2UV3RN6GPTANCNFSM4MNXU24A>.
|
OK. Here's feedback from Dan: Looks like he's trying to push the branch to the realpython/materials repo, he needs to create a fork under his account first: |
Thanks
I tried to create a pull request from the forked repo on my mac.
I get this error, prepared to admin I’m not much good at creating a pull request,
any suggestions, I looked at the help and used source tree from atlassian to create the pull request,.
git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags --set-upstream origin refs/heads/python3.8_mac_mojave:refs/heads/python3.8_mac_mojave
Pushing to git@github.com:realpython/materials.git
ERROR: Permission to realpython/materials.git denied to eddo888.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Completed with errors, see above
… On 23 Apr 2020, at 10:53 am, Jim Anderson ***@***.***> wrote:
@eddo888 <https://github.com/eddo888> Wow! Super cool! I'd love to see it. Can you make a PR from your branch/fork?
Thanks!
jima
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAT5IL52KD4IV4NOYED2UV3RN6GPTANCNFSM4MNXU24A>.
|
You need to create the pull request through the GitHub UI, please see: |
Thankyou, understood, however I don’t have the permissions to put a branch into your repo
… On 19 May 2020, at 2:33 pm, Dan Bader ***@***.***> wrote:
You need to create the pull request through the GitHub UI, please see:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request <https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request>
https://www.youtube.com/watch?v=rgbCcBNZcdQ <https://www.youtube.com/watch?v=rgbCcBNZcdQ>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAT5IL2XNYD6KNWBGHMVQFDRSID2JANCNFSM4MNXU24A>.
|
@eddo888 No problem David, the first step is to fork the repository under your own account, as explained here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork Then you can create a pull request against this repo from your fork. |
This seems like a nice addition. Maybe you guys should just add it, because eddo888 seems to have gone poof |
Hi, I have a branch to push to you with a working version of the python binding module
with Mac Mojave and Python 3.8 using python.org version of python, (not brew)
Cheers Dave.
Notes here;
help on python c binding
dependencies
install python3.8 from python.org
security block
mac mojave blocks relative pathed libraries, here is the fix
install_name_tool
mac G++ missing symbols
mac compile gets upset about missing symbols
ignore missing symbols on a mac
in task.py
compile and test
here is the output from a good compile and test run
The text was updated successfully, but these errors were encountered: