Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest-xdist 2.0.0 compatibility #101

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Add pytest-xdist 2.0.0 compatibility #101

merged 1 commit into from
Aug 22, 2020

Conversation

leorochael
Copy link
Contributor

@leorochael leorochael commented Aug 20, 2020 •
edited
Loading

Attempt fetching the workerinput config node attribute using both the
new and the old name.

Adjust tox version to test the new xdist with the new pytest only.

Fixes: #100

@leorochael
Add pytest-xdist 2.0.0 compatibility
6d91c83 
Attempt fetching the `workerinput` config node attribute using both the
new and the old name.

Adjust tox version to test the new xdist with the new pytest only.
@leorochael leorochael mentioned this pull request Aug 20, 2020
Closed
@leorochael
Copy link
Contributor Author

leorochael commented Aug 20, 2020 •
edited
Loading

The CI tests are running with Using --randomly-seed=1597962249, which means breakages between pytest-randomly and pytest-xdist won't show up.

They shouldn't show up anyway because I believe I pinned the right xdist/randomly versions to avoid that, but I only realised the need to pin the right combinations because I ran tox locally.

dmtucker
dmtucker approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@dmtucker dmtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you 👍

@dmtucker dmtucker added this to the 0.7.0 milestone Aug 22, 2020
@dmtucker
Copy link
Collaborator

The CI tests are running with Using --randomly-seed=1597962249, which means breakages between pytest-randomly and pytest-xdist won't show up.

I'm not sure I follow 🤔 That seed should not be fixed for more than one session.

They shouldn't show up anyway because I believe I pinned the right xdist/randomly versions to avoid that, but I only realised the need to pin the right combinations because I ran tox locally.

Ok, I won't hold the merge on this then. The Validation workflow seems good with it ☺️

@dmtucker dmtucker merged commit be80b7b into realpython:master Aug 22, 2020
@dmtucker dmtucker mentioned this pull request Aug 23, 2020
Closed
@dmtucker dmtucker mentioned this pull request Nov 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtucker dmtucker dmtucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

pytest-xdist 2 support
2 participants
@leorochael @dmtucker