Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py34, add GitHub Actions and a tox env for publishing #92

Merged
merged 4 commits into from
Jul 21, 2020

Conversation

dmtucker
Copy link
Collaborator

Close #46

py34 has reached EOL, and tox-gh-actions does not support it.

Dropping support should not affect the vast majority of active users.
In the last 30 days, py34 accounted for only 0.003% of pytest-mypy downloads:

$ pypinfo pytest-mypy pyversion
Served from cache: False
Data processed: 117.47 GiB
Data billed: 117.47 GiB
Estimated cost: $0.58

| python_version | download_count |
| -------------- | -------------- |
| 3.7            |         56,011 |
| 3.8            |         18,070 |
| 3.6            |         15,508 |
| 3.9            |            678 |
| 3.5            |            324 |
| 3.10           |             90 |
| 2.7            |             28 |
| 3.4            |              3 |
| Total          |         90,712 |

Switching to GitHub Actions should more permanently resolve #46; however, we can't use it to replace Travis CI entirely without @dbader's help (because admin privileges are required to set repo Secrets, which we would need for PyPI creds e.g. https://github.com/dmtucker/backlog/blob/10701deae4fde379d281808184c3c715b53a980a/.github/workflows/publication.yml#L15-L16)

@dmtucker dmtucker added this to the 0.6.3 milestone Jul 21, 2020
@dmtucker
Copy link
Collaborator Author

Hmm... Actions don't appear to be running 🤔 It works in my fork, though, maybe PR checks begin after the workflow has been committed for the first time?

@dmtucker dmtucker merged commit f243369 into realpython:master Jul 21, 2020
@dmtucker dmtucker deleted the actions branch July 21, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TravisCI times out
1 participant