Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDM120CT #41

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Added SDM120CT #41

merged 1 commit into from
Dec 13, 2019

Conversation

jeroenst
Copy link

No description provided.

@reaper7
Copy link
Owner

reaper7 commented Dec 13, 2019

can You provide a link to the documentation for this module?
I found this one: http://www.ett.co.th/productDIN/SDM120CT-MV/SDM120CT%20PROTOCOL.pdf
and in above doc not all registers, posted by you, are documented

Copy link
Author

@jeroenst jeroenst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I don't know anymore where I got these. I made the code over a year ago. I will change it according to the available registers, and create a new commit.

@reaper7
Copy link
Owner

reaper7 commented Dec 13, 2019

I found that sdm120 and sdm120ct have the same registers:
http://www.eastroneurope.com/media/_system/tech_specs/3914/SDM120%20PROTOCOL.pdf
http://www.ett.co.th/productDIN/SDM120CT-MV/SDM120CT%20PROTOCOL.pdf

only sdm120c has several registers less

@jeroenst
Copy link
Author

You're right... I leave it up to you if you want to accept my pull request with new commit
0bf40c8

@reaper7 reaper7 merged commit 37eeeea into reaper7:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants