Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added registers for DDM18SD #44

Closed
wants to merge 1 commit into from
Closed

Conversation

jeroenst
Copy link

No description provided.

@reaper7
Copy link
Owner

reaper7 commented Apr 28, 2020

Hi!
Have you tested this device? it works?

@jeroenst
Copy link
Author

Not yet, I did integrate the registers from the documentation. I will receive the device 15-5-2020 and will install and test it the same day.

To be continued...

@reaper7
Copy link
Owner

reaper7 commented Apr 29, 2020

Ok, then we'll wait for physical tests...
if everything goes well we will add Your integration.

Let me know when you check.

@jeroenst
Copy link
Author

Sorry, I don't think I will use this device soon, for now I use a zmai90. So at this moment I won't test this code.

@jeroenst jeroenst closed this Jun 11, 2020
@Jestergnet
Copy link

Jestergnet commented Oct 28, 2020

I saw the code, I'm checking it. Made changes, asked for it and nothing changed? What do I need to do?

@Jestergnet
Copy link

I checked it works.

@jeroenst jeroenst reopened this Oct 29, 2020
@jeroenst
Copy link
Author

Please merge now or has been tested.

@reaper7
Copy link
Owner

reaper7 commented Oct 30, 2020

Please update your copy of this repo because structure of SDM.h and nomenclature of registry names has been changed.
You must create definitions for the new device according to the example from SDM.h (example from lines 194-202)

@reaper7
Copy link
Owner

reaper7 commented Oct 31, 2020

done!

@reaper7 reaper7 closed this Oct 31, 2020
@digimp
Copy link

digimp commented Feb 3, 2021

Looking for see this device (DDM18SD) working found your contribution here. On the code of the tasmota sensor there isn't , or I have'nt found, nothing for this device. So finally this is the reason why it doesn't work in my hands. Do I have to add this register on a override file or I have to start to compile a full file from the beginning to the end ?

@reaper7
Copy link
Owner

reaper7 commented Feb 3, 2021

I don't use tasmota and I don't know how it's built...
You can try of course ...

@digimp
Copy link

digimp commented Feb 3, 2021

Ah, thanks for quick answer! I'll try to do what I can, not easy. Thanks for your work, I'll have anyway the chance to read my meter.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants