Add dune file #709
Merged
Add dune file #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Mar 20, 2023
| (library | ||
| (name reason_react) | ||
| (wrapped false) | ||
| (flags :standard -bs-jsx 3) |
There was a problem hiding this comment.
depending which melange version you install this could be changed to (preprocessing (pps reactjs-jsx-ppx))
There was a problem hiding this comment.
Since I don't want to install melange here yet, this will be updated when I replace bs-platform entirely with Melange (hopefully in opam) + reactjs-jsx-ppx
davesnx
force-pushed
the
Add-dune-file
branch
3 times, most recently
from
c043e29 to
008dcc2
Compare
davesnx
added a commit
that referenced
this pull request
Mar 20, 2023
…k-deprecation-warning-push-old-readme * 'main' of github.com:/reasonml/reason-react: Push CRLF issues Add dune file (#709)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the consumption of reason_react as melange dependency but it maintains the building with bs-platform and dune