-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add react.fragment with key #750
test: add react.fragment with key #750
Conversation
03ac1df
to
2936262
Compare
Found some interesting change when testing this branch. The following code would compile before without issues: let resultRow = twitterAuthor =>
<tr key={twitterAuthor.EndpointT.screen_name}>
<td className="DetailsWhoTweeted-col--avatar">
<div className=Css.avatarContainer>
<CeAvatarIcon
src={Some(String.replace(twitterAuthor.profile_image_url->Wrap.Url.show, "http://", "https://"))}
/>
</div>
</td>
</tr> With this branch (or maybe, after the changes in #714? not sure), it triggers this error:
Edit: created #752 to discuss this separately. |
@anmonteiro I updated the branch with latest Feel free to merge whenever you think is ready (I can't approve as the creator of the branch). |
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
9127eee
to
8c12ff8
Compare
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
It seems there's been a recent regression that involves
React.Fragment
andkey
attribute. It was possible to useoption(string)
before while now the code does not type check.