Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle 0 value durations #259

Merged
merged 2 commits into from
Sep 12, 2024
Merged

handle 0 value durations #259

merged 2 commits into from
Sep 12, 2024

Conversation

steppy452
Copy link
Contributor

@steppy452 steppy452 commented Sep 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

0 value durations were bring treated as undefined/null values

Issue Number: N/A

What is the new behavior?

returns 0 ms when value is 0

image

also added a custom zero value story

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit ca93f66
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66e20a082565ad0008c3338a
😎 Deploy Preview https://deploy-preview-259--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/data/Duration/utils.ts Outdated Show resolved Hide resolved
@amcdnl amcdnl merged commit edbcfbb into master Sep 12, 2024
5 checks passed
@amcdnl amcdnl deleted the syang/durtaion-bug branch September 12, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants