Improve scroll consistency on diff devices #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reaflow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amcdnl
requested changes
Jul 10, 2024
docs/Advanced/Refs.mdx
Outdated
| @@ -86,11 +86,11 @@ export interface CanvasRef { | |||
| /** | |||
| * Zoom in on the canvas. | |||
| */ | |||
| zoomIn?: () => void; | |||
| zoomIn?: (zoomFactor: number) => void; | |||
There was a problem hiding this comment.
requiring a zoomFactor makes this a breaking change. could we default it to something so we don't have to break existing apis ?
There was a problem hiding this comment.
oops yea that should be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Charts tend to zoom much faster on trackpads than mouse wheels (when using panType=drag)
What is the new behavior?
Chart zooming feels consistent across input devices
Does this PR introduce a breaking change?
Other information
This determines zoom strength based off the amount of pixels in the scroll event delta's instead of the amount of scroll events sent (trackpads send alot of little scrolls, mouse wheels send fewer larger scrolls)