Include portable-pdbs in nuget package and enable SourceLink #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
So this won't work with older Visual Studio versions, the alternative is to use "non-portable" pdbs and GitLink, but that is more complicated to set up and ultimately deprecated anyways. |
|
Uhh it breaks CI, seems that it doesn't do a regular git checkout. |
poizan42
force-pushed
the
master
branch
2 times, most recently
from
4ecd8f6
to
80a7a23
Compare
|
So I disabled SourceLink when building from CI |
|
coool 👍 |
|
Rebus 5.0.0-b18 has PDBs in the NuGet package now, and I just pushed it to NuGet.org. Thanks for fixing this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new SourceLink v2 support available in Visual Studio 2017 15.3+. pdb files are included in the nuget package as recommended by Microsoft.
Fixes #730
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.