Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New support for Application Migration Service (MGN) resources #1024 #1025

Merged
merged 9 commits into from
Jun 28, 2023
Merged

New support for Application Migration Service (MGN) resources #1024 #1025

merged 9 commits into from
Jun 28, 2023

Conversation

joelee
Copy link
Contributor

@joelee joelee commented Jun 12, 2023 •
edited
Loading

Removal of all AWS Application Migration Service (MGN) Source Servers and Migration Jobs as requested on #1024

@joelee joelee requested a review from a team as a code owner June 12, 2023 16:28
@joelee joelee mentioned this pull request Jun 13, 2023
Closed
@joelee joelee changed the title Feature/1024 nuking mgn resources Add support for Application Migration Service (MGN) resources #1024 Jun 13, 2023
@joelee joelee changed the title Add support for Application Migration Service (MGN) resources #1024 New support for Application Migration Service (MGN) resources #1024 Jun 13, 2023
@der-eismann
Copy link
Member

Hey @joelee, thanks for the PR! However I would kindly ask you to replace Mgn with MGN and add Properties() functions for the resources, since these can hold more data than the String() (example).

der-eismann
der-eismann previously approved these changes Jun 27, 2023
View reviewed changes
bjoernhaeuser
bjoernhaeuser reviewed Jun 28, 2023
View reviewed changes
resources/mgn-jobs.go Outdated Show resolved Hide resolved
resources/mgn-source_servers.go Outdated Show resolved Hide resolved
@der-eismann der-eismann merged commit d5c6a0d into rebuy-de:main Jun 28, 2023
2 checks passed
@joelee joelee deleted the feature/1024-Nuking_MGN_Resources branch June 28, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernhaeuser bjoernhaeuser bjoernhaeuser approved these changes

@der-eismann der-eismann der-eismann approved these changes

@svenwltr svenwltr Awaiting requested review from svenwltr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelee @der-eismann @bjoernhaeuser