Stopped Executions before deleting step functions state machines #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernhaeuser
previously approved these changes
Aug 2, 2023
der-eismann
reviewed
Aug 2, 2023
resources/sfn-statemachines.go
Outdated
| StateMachineArn: f.ARN, | ||
| } | ||
|
|
||
| for{ |
There was a problem hiding this comment.
Can you please run go fmt to fix the formatting here?
auto-merge was automatically disabled
August 13, 2023 11:51
Head branch was pushed to by a user without write access
der-eismann
approved these changes
Aug 23, 2023
svenwltr
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we have created state machines in step functions, and have enabled executions within those state machines, we sometimes have trouble in deleting those state machines. This PR fixes that.
Repro
Create a state machine, with
waitmodule (in flow tab, ig), this will have the executions in running state for that duration. Trying to delete state machine would fail because of on-going executions. We have to stop executions, for that state machine.