Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

appconfig: add support for five resources #1055

Merged
merged 2 commits into from
Aug 2, 2023
Merged

appconfig: add support for five resources #1055

merged 2 commits into from
Aug 2, 2023

Conversation

tbarrella
Copy link
Contributor

@tbarrella tbarrella commented Jul 26, 2023 •
edited
Loading

Adds support for

  • Application
  • ConfigurationProfile
  • DeploymentStrategy
  • Environment
  • HostedConfigurationVersion

As part of #1058

@tbarrella
appconfig: add support for five resources
b6447f2 
Signed-off-by: Taylor Barrella <tbarrella@gmail.com>
@tbarrella tbarrella requested a review from a team as a code owner July 26, 2023 01:11
bjoernhaeuser
bjoernhaeuser reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@bjoernhaeuser bjoernhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need paging for these resources as well

@tbarrella
Copy link
Contributor Author

Mm, anything in particular I need to add/change? I used the List*Pages APIs

bjoernhaeuser
bjoernhaeuser approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@bjoernhaeuser bjoernhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i was wrong

@bjoernhaeuser bjoernhaeuser enabled auto-merge (squash) August 2, 2023 13:36
@bjoernhaeuser bjoernhaeuser merged commit 2bef99a into rebuy-de:main Aug 2, 2023
2 checks passed
@der-eismann der-eismann mentioned this pull request Aug 16, 2023
Merged
@der-eismann der-eismann mentioned this pull request Aug 23, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bjoernhaeuser bjoernhaeuser bjoernhaeuser approved these changes

@der-eismann der-eismann der-eismann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbarrella @bjoernhaeuser @der-eismann