Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Fix: Don't delete predefined deployment strategies #1081

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix: Don't delete predefined deployment strategies #1081

merged 1 commit into from
Aug 23, 2023

Conversation

der-eismann
Copy link
Member

@der-eismann der-eismann commented Aug 23, 2023 •
edited
Loading

Unfortunately there was another error in the AppConfig code, as it caused some of these:

BadRequestException: Cannot delete predefined Deployment Strategy AppConfig.Linear50PercentEvery30Seconds
Message_:  "Cannot delete predefined Deployment Strategy AppConfig.Linear50PercentEvery30Seconds."

This change should fix it.

/cc @tbarrella

@der-eismann der-eismann marked this pull request as ready for review August 23, 2023 14:33
@der-eismann der-eismann requested a review from a team as a code owner August 23, 2023 14:33
@der-eismann der-eismann merged commit 88607f3 into main Aug 23, 2023
2 checks passed
@der-eismann der-eismann deleted the dont-delete-predefined-deployment-strategy branch August 23, 2023 14:55
@der-eismann der-eismann mentioned this pull request Aug 23, 2023
Closed
@fernandoataoldotcom fernandoataoldotcom mentioned this pull request Aug 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@svenwltr svenwltr svenwltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@der-eismann @svenwltr