Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add pagination to the multiple resources #1158

Closed
wants to merge 2 commits into from

Conversation

josesolisrosales
Copy link

@josesolisrosales josesolisrosales commented Nov 21, 2023

Description

The ListIAMUserPolicies lacks pagination support. When trying to delete over 100 Users with policies attached aws_nuke will fail as it will only remove the policies for the first 100 Users listed.

users, err := svc.ListUsers(nil)

Verbose output shows isTruncated response element:

DEBU[0007] received AWS response:
    < HTTP/1.1 200 OK
    < Content-Length: 27788
    < Content-Type: text/xml
    < Date: Tue, 21 Nov 2023 19:13:45 GMT
    < X-Amzn-Requestid: *****
    <
    < <ListUsersResponse xmlns="https://iam.amazonaws.com/doc/2010-05-08/">
    <   <ListUsersResult>
    <     <IsTruncated>true</IsTruncated>
    .
    .
    .

fixes #1159

@josesolisrosales josesolisrosales changed the title Add pagination support to the ListIAMUserPolicies function Add pagination to the multiple resources Nov 21, 2023
@josesolisrosales
Copy link
Author

This is also happening in the ListIAMUserGroupAttachments function. Added changes to the PR

@ekristen
Copy link
Contributor

Please feel free to open a PR on https://github.com/ekristen/aws-nuke or an issue, otherwise I'll add it to my backlog.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of pagination support for multiple list functions
2 participants