Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Delete DMS Certificate not Endpoint in DatabaseMigrationServiceCertificate Remove function #1164

Closed
wants to merge 1 commit into from

Conversation

tsndqst
Copy link

@tsndqst tsndqst commented Dec 7, 2023

It appears that DatabaseMigrationServiceCertificate was created with copy/paste and some values weren't changed. I think this change will allow aws-nuke to delete DMS certificates when removing resources. Currently aws-nuke leaves DMS certificates around when destroying AWS accounts.

@tsndqst tsndqst requested a review from a team as a code owner December 7, 2023 21:28
@twispt
Copy link

twispt commented Jan 4, 2024

bump

@ekristen
Copy link
Contributor

@tsndqst unfortunately I could not cherry pick this commit due to the divergence in the fork, however this is being implemented in the PR ekristen/aws-nuke#329 -- many thanks.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 30, 2024
@tsndqst
Copy link
Author

tsndqst commented Sep 30, 2024

Thanks @ekristen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants