Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add support for Sagemaker Spaces #1197

Conversation

npellegrin
Copy link
Contributor

@npellegrin npellegrin commented Mar 2, 2024

This change adds the deletion of SageMaker spaces, and fixes the deletion problem impacting SageMaker Apps when associated to Spaces (a SageMaker app can be associated with either a user profile or a space)

Closes #1184
Likely closes #1004 but there is no log in the issue to be certain of the dependency problem reported
Likely closes #1216 as well.

Output with feature activated

aws-nuke version b89af78.dirty - Sat Mar  2 11:18:38 CET 2024 - b89af78ba2bbbd0e5e875c430330be0fdce7c45e

Do you really want to nuke the account with the ID 000000000000 and the alias 'nuke-me'?
Do you want to continue? Enter account alias to continue.
> nuke-me

eu-west-3 - SageMakerSpace - jupyter-dev - [DomainID: "d-xxx", LastModifiedTime: "2024-03-01 13:47:26.604 +0000 UTC", SpaceName: "jupyter-dev", Status: "InService"] - would remove
eu-west-3 - SageMakerApp - default - [AppName: "default", AppType: "JupyterLab", DomainID: "d-xxx", SpaceName: "jupyter-dev"] - would remove
eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - would remove
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - would remove
Scan complete: 4 total, 4 nukeable, 0 filtered.

Do you really want to nuke these resources on the account with the ID 000000000000 and the alias 'nuke-me'?
Do you want to continue? Enter account alias to continue.
> nuke-me

eu-west-3 - SageMakerSpace - jupyter-dev - [DomainID: "d-xxx", LastModifiedTime: "2024-03-01 13:47:26.604 +0000 UTC", SpaceName: "jupyter-dev", Status: "InService"] - failed
eu-west-3 - SageMakerApp - default - [AppName: "default", AppType: "JupyterLab", DomainID: "d-xxx", SpaceName: "jupyter-dev"] - triggered remove
eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - failed
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - failed

Removal requested: 1 waiting, 3 failed, 0 skipped, 0 finished

eu-west-3 - SageMakerSpace - jupyter-dev - [DomainID: "d-xxx", LastModifiedTime: "2024-03-01 13:47:26.604 +0000 UTC", SpaceName: "jupyter-dev", Status: "InService"] - waiting
eu-west-3 - SageMakerApp - default - [AppName: "default", AppType: "JupyterLab", DomainID: "d-xxx", SpaceName: "jupyter-dev"] - removed
eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - failed
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - failed

Removal requested: 1 waiting, 2 failed, 0 skipped, 1 finished

eu-west-3 - SageMakerSpace - jupyter-dev - [DomainID: "d-xxx", LastModifiedTime: "2024-03-01 13:47:26.604 +0000 UTC", SpaceName: "jupyter-dev", Status: "InService"] - removed
eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - triggered remove
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - failed

Removal requested: 1 waiting, 1 failed, 0 skipped, 2 finished

eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - waiting
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - triggered remove

Removal requested: 2 waiting, 0 failed, 0 skipped, 2 finished

eu-west-3 - SageMakerUserProfiles - default-000 - [DomainID: "d-xxx", UserProfileName: "default-000"] - removed
eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - waiting

Removal requested: 1 waiting, 0 failed, 0 skipped, 3 finished

eu-west-3 - SageMakerDomain - d-xxx - [DomainID: "d-xxx"] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 4 finished

Nuke complete: 0 failed, 0 skipped, 4 finished.

@ekristen
Copy link
Contributor

@npellegrin this PR was cherry-picked as explained by this PR ekristen/aws-nuke#158 and merged into the actively maintained fork of aws-nuke.

If you have a change to try it out, that would be great. If you run into issues, please report it in an issue over there.


Please see a copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants