ensure ELB deletion works with > 20 load balancers; remove all S3 object versions #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of load balancers exceeds 20, then the DescribeTags fails.
svenwltr
reviewed
Feb 22, 2019
resources/s3-object-versions.go
Outdated
| ) | ||
|
|
||
| // DeleteListVersionListIterator is an iterator for S3 Object Versions. | ||
| type DeleteVersionListIterator struct { |
There was a problem hiding this comment.
The type name should contain S3, so the name makes clear what service the resource belongs to. Also the file name should match the type name.
Since the type is only used by S3Bucket I think it should even be part of s3-buckets.go, since we should keep the number of files low.
There was a problem hiding this comment.
Makes sense. I actually originally had it in s3-buckets.go, I'll move it back.
svenwltr
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadBalancerNamesallows only a maximum of 20 names in a list before bombing out, so call theDescribeTagsfunction on each load balancer in a loop even though it's more inefficient.Removing all S3 objects is unfortunately not enough if versioning is enabled. This PR empties all object versions as well.