-
Notifications
You must be signed in to change notification settings - Fork 723
Add support for ECS capacity providers #876
Conversation
Hey @Octogonapus, thanks for your submission!
That would be the ideal case - I assume you created this PR because you want to delete something. Trying out if it works is the best way. We don't really have tests for that. |
I ran this on my own account. Found one problem related to removing reserved capacity providers and pushed a fix for that. There is another problem, similar to #877. Capacity providers are associated with clusters and cannot be deleted without first being disassociated from those clusters. If you are deleting the cluster as well, simply running aws-nuke twice would work around this, but I think that some explicit ordering between these two steps is desirable. Apart from that, I think this is working. |
@Octogonapus I believe that is the preferred approach as |
Ok, if aws-nuke doesn't want to implement any kind of dependency management, then this is RTM. |
Sorry for coming back to this to late, not sure if this is now provided by the cloud-control APIs? |
I had a look at the cloud control stuff, but I don't understand it. If aws-nuke now supports deleting ECS capacity providers, this can be closed. |
7140e87
to
40bcf8d
Compare
Rebased on the latest main branch. Would be good to get this in because aws-nuke still does not delete capacity providers. |
@Octogonapus this is going to be implemented via ekristen/aws-nuke#320 on what is now the active managed fork of aws-nuke as such I'm closing this PR. Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information. Caution This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke. |
This PR adds support for ECS capacity providers.
I'm not sure how to test this. I didn't notice tests in this pkg. I could try running it on my own resources?