Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add support for ECS capacity providers #876

Closed

Conversation

Octogonapus
Copy link

@Octogonapus Octogonapus commented Nov 8, 2022

This PR adds support for ECS capacity providers.

I'm not sure how to test this. I didn't notice tests in this pkg. I could try running it on my own resources?

@Octogonapus Octogonapus requested a review from a team as a code owner November 8, 2022 15:51
@der-eismann
Copy link
Member

Hey @Octogonapus, thanks for your submission!

I could try running it on my own resources?

That would be the ideal case - I assume you created this PR because you want to delete something. Trying out if it works is the best way. We don't really have tests for that.

@Octogonapus
Copy link
Author

Octogonapus commented Nov 8, 2022

I ran this on my own account. Found one problem related to removing reserved capacity providers and pushed a fix for that.

There is another problem, similar to #877. Capacity providers are associated with clusters and cannot be deleted without first being disassociated from those clusters. If you are deleting the cluster as well, simply running aws-nuke twice would work around this, but I think that some explicit ordering between these two steps is desirable.

Apart from that, I think this is working.

@sstoops
Copy link
Contributor

sstoops commented Feb 14, 2023

simply running aws-nuke twice would work around this

@Octogonapus I believe that is the preferred approach as aws-nuke does not maintain any sort of dependency chain. Many other resources operate in this manner where one may fail while something related is removed, then the second run cleans up the parent resource.

@Octogonapus
Copy link
Author

Ok, if aws-nuke doesn't want to implement any kind of dependency management, then this is RTM.

@bjoernhaeuser
Copy link
Member

Sorry for coming back to this to late, not sure if this is now provided by the cloud-control APIs?

@Octogonapus
Copy link
Author

I had a look at the cloud control stuff, but I don't understand it. If aws-nuke now supports deleting ECS capacity providers, this can be closed.

@Octogonapus
Copy link
Author

Rebased on the latest main branch. Would be good to get this in because aws-nuke still does not delete capacity providers.

@ekristen
Copy link
Contributor

@Octogonapus this is going to be implemented via ekristen/aws-nuke#320 on what is now the active managed fork of aws-nuke as such I'm closing this PR.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants