Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CloudWatchLogsLogGroup): null pointer exception when log group di… #928

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

optplx
Copy link
Contributor

@optplx optplx commented Feb 6, 2023

…d never ingest anything

I did previously assume that if we had a logstream, we had necessarily events in it, which is actually not always the case. This happened to me this morning: we had a loggroup with a logstream, but no events.

ERRO[0020] Listing CloudWatchLogsLogGroup failed:
    runtime error: invalid memory address or nil pointer dereference

    goroutine 44 [running]:
    runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65
    github.com/rebuy-de/aws-nuke/v2/cmd.(*scanner).list.func1()
        /src/cmd/scan.go:49 +0x78
    panic({0x49be0c0, 0x8edc7b0})
        /usr/local/go/src/runtime/panic.go:884 +0x212
    github.com/rebuy-de/aws-nuke/v2/resources.ListCloudWatchLogsLogGroups(0xc000424d80?)
        /src/resources/cloudwatchlogs-loggroups.go:60 +0x3e3
    github.com/rebuy-de/aws-nuke/v2/cmd.(*scanner).list(0xc0004b9cf0, 0xc000424d80, {0x57418cf, 0x16})
        /src/cmd/scan.go:60 +0x122
    created by github.com/rebuy-de/aws-nuke/v2/cmd.(*scanner).run
        /src/cmd/scan.go:37 +0x145 

@optplx optplx requested a review from a team as a code owner February 6, 2023 10:28
@DanielCastronovo
Copy link

Hello, any news ?

@der-eismann der-eismann merged commit 392093a into rebuy-de:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants