-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(features)The delete function for cloudwatch rum is added #952
Conversation
example output dryrun:
example output nodryrun:
|
Can this be merged? Pretty straightforward. |
Hi @dza89 , I'm not a maintainer, but I will make the observation that you've implemented the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wei-zhong90, thanks for your PR and sorry for the late reply! Could you implement the small change I suggested so we can get this merged?
Change the naming convention to conform to the general style as suggested Co-authored-by: Philipp Trulson <der-eismann@users.noreply.github.com>
Just add the delete function for cloudwatch-rum appmonitor resource