Filter main route tables #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this PR will get looked at? |
|
Hey @leighpascoe, sorry for the late reply. We already have a dedicated |
|
great. thank you. I'll make that change |
|
@der-eismann I've made the update, and tested it. Ready for re-review |
|
@svenwltr and @der-eismann Could I please get this re-reviewed. We are looking forward to using the released container instead of building our own forked image |
|
@svenwltr, Am I missing anything in this PR? |
|
@der-eismann We have been using aws-nuke on this custom branch for the last 4 months to delete VPC, it's well tested. Could we please get this reviewed and merged? |
der-eismann
approved these changes
Aug 15, 2023
bjoernhaeuser
approved these changes
Aug 15, 2023
use `Filter` instead of custom method
bjoernhaeuser
force-pushed
the
filter-main-route-tables
branch
from
14b4d6e
to
ae6bd3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS does not allow you to delete main route tables, see AWS docs.
Aws-nuke wants to delete a VPC, it expects the main route table to be deleted first, the main route table cannot be deleted, therefore the VPC fails to delete due to a dependency error.
Proposed Solution
After Describing the route tables, check for any
AssociationswhereMainistrue. There may be zero to many Associations. If at least onemainAssociation is found on the Toute Table, then the Route Table will will not be added to the returned collection of Route TablesI have tested this on VPC with just a main route table, as well as VPC's with multiple route tables.
Related Issues: #946 #785