Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all ACM Certificate key types to query #962

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add all ACM Certificate key types to query #962

merged 1 commit into from
Mar 17, 2023

Conversation

sstoops
Copy link
Contributor

@sstoops sstoops commented Mar 15, 2023

By default, the ListCertificates method only lists RSA_2048 key types. This leaves many other types unlisted and unhandled by AWS Nuke.

Default filtering returns only RSA_2048 certificates. For more information, see Filters.

Ref: https://docs.aws.amazon.com/sdk-for-go/api/service/acm/#ACM.ListCertificates

This PR adds all supported types to the query.

Testing performed

  • Create via the Web Console a key using "ECDSA P 256".
  • Import a certificate using "RSA 4096".
  • Run AWS Nuke and ensure these have been removed.

@sstoops sstoops requested a review from a team as a code owner March 15, 2023 23:51
@svenwltr svenwltr enabled auto-merge (squash) March 17, 2023 14:59
@svenwltr svenwltr merged commit d7d77a2 into rebuy-de:main Mar 17, 2023
@sstoops sstoops deleted the acm-cert-keytypes branch April 26, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenwltr svenwltr svenwltr approved these changes

@der-eismann der-eismann der-eismann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstoops @svenwltr @der-eismann