This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
adds sample k8s manifests and updates readme #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanlindauer
approved these changes
Sep 13, 2018
svenwltr
reviewed
Sep 13, 2018
README.md
Outdated
| @@ -40,7 +40,10 @@ node-drainer --access-key-id example_id --secret-access-key example_secret --reg | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Binaries and packages are not provided for *node-drainer*. To have it installed one must compile it from source. | |||
| Binaries for *node-drainer* are provided for each release [here](https://github.com/rebuy-de/node-drainer/releases). | |||
There was a problem hiding this comment.
I think this should be a list.
README.md
Outdated
| @@ -40,7 +40,10 @@ node-drainer --access-key-id example_id --secret-access-key example_secret --reg | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Binaries and packages are not provided for *node-drainer*. To have it installed one must compile it from source. | |||
| Binaries for *node-drainer* are provided for each release [here](https://github.com/rebuy-de/node-drainer/releases). | |||
| Docker containers are are provided [here](https://quay.io/repository/rebuy/node-drainer). | |||
There was a problem hiding this comment.
I would add the image URL for the master tag.
readme is updated with correct installation information - binary downloads - docker image download samples folder was added, hosting sample kubernetes manifest files for configuring node-drainer inside a k8s cluster
octopusx
force-pushed
the
update_readme_installation
branch
from
399e1cd
to
26a5127
Compare
|
@svenwltr hey, I updated the pull request with changes you suggested, please take a look and see if it's to your liking. |
stephanlindauer
approved these changes
Sep 18, 2018
svenwltr
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme is updated with correct installation information
samples folder was added, hosting sample kubernetes manifest files for
configuring node-drainer inside a k8s cluster
@rebuy-de/prp-node-drainer please review