Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add react 17 to peer deps #46

Closed
wants to merge 1 commit into from

Conversation

Zertz
Copy link

@Zertz Zertz commented Feb 5, 2021

This will suppress messages similar to this:

warning "recharts > react-smooth@1.0.6" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning "recharts > react-smooth@1.0.6" has incorrect peer dependency "react-dom@^15.0.0 || ^16.0.0".

@bradtgmurray
Copy link

FYI I also made the same change in #47 and confirmed that npm demo was happy when running with react 17.

@semoal
Copy link

semoal commented Mar 8, 2021

@xile611 can we move this to base branch please?

@Zertz
Copy link
Author

Zertz commented Mar 8, 2021

Without the ability to run Enzyme tests with React 17, it's understandable the maintainers may not want to merge this just yet.

On our end, it's just the minor annoyance of a few warnings.

@semoal
Copy link

semoal commented Mar 8, 2021

Without the ability to run Enzyme tests with React 17, it's understandable the maintainers may not want to merge this just yet.

On our end, it's just the minor annoyance of a few warnings.

That's not a problem.
#48
I've refactored the testing suite to use jest with testing-library and React 17, tests passed correctly and everything is working fine.

;)

@Zertz Zertz closed this Mar 8, 2021
@Zertz Zertz deleted the patch-1 branch March 8, 2021 18:57
@cmmartin
Copy link

Is this released? I'm getting an error using the latest version of recharts with react 17.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from react-smooth@1.0.6
npm -v
7.0.15

@semoal
Copy link

semoal commented Mar 12, 2021

This not released yet. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants