Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl num-traits (fixes #226) #298

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Impl num-traits (fixes #226) #298

merged 11 commits into from
Aug 28, 2023

Conversation

recmo
Copy link
Owner

@recmo recmo commented Aug 27, 2023

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@recmo recmo mentioned this pull request Aug 27, 2023
3 tasks
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 32.66% and project coverage change: -2.21% ⚠️

Comparison is base (b3b7d84) 82.52% compared to head (19013ec) 80.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   82.52%   80.31%   -2.21%     
==========================================
  Files          53       54       +1     
  Lines        5704     5994     +290     
==========================================
+ Hits         4707     4814     +107     
- Misses        997     1180     +183     
Files Changed Coverage Δ
ruint-macro/src/lib.rs 96.42% <ø> (ø)
src/bytes.rs 96.81% <ø> (ø)
src/support/num_traits.rs 21.70% <21.70%> (ø)
src/bits.rs 77.57% <100.00%> (+5.60%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@recmo recmo changed the title Impl num-traits Impl num-traits (fixes #226) Aug 27, 2023
@recmo recmo self-assigned this Aug 27, 2023
@recmo recmo marked this pull request as ready for review August 27, 2023 23:36
@recmo recmo requested a review from prestwich as a code owner August 27, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant