Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added keyboard text selection support #118

Merged
merged 83 commits into from
Sep 30, 2024
Merged

Added keyboard text selection support #118

merged 83 commits into from
Sep 30, 2024

Commits on Jul 9, 2024

  1. Adapted user select action usage

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    21677a9 View commit details
    Browse the repository at this point in the history

  2. Made the content focusable

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    580082b View commit details
    Browse the repository at this point in the history

  3. Generalized down event recording

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e9832d5 View commit details
    Browse the repository at this point in the history

  4. Added explicit pointer event cloning

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1168059 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Added keyboard event registering

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ffa46eb View commit details
    Browse the repository at this point in the history

  2. Re-exported select action

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0bbe064 View commit details
    Browse the repository at this point in the history

  3. Fixed keyboard selection detection w/o prior pointer event

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    268c6e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Added keyboard selection finish handling

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1780bf0 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Allowed shifting over the selection content

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    11aae73 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'refs/heads/main' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator/src/TextAnnotator.css
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ae27926 View commit details
    Browse the repository at this point in the history

  2. Added reaction to the user event

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e4a4b69 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'refs/heads/main' into keyboard-event-selection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5fb2789 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/main' into keyboard-event-selection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    461bcac View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Added annotation discarding when the selection collapses

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    719edaf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    753cee9 View commit details
    Browse the repository at this point in the history

  3. Updated currentTarget check comment

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e20c04e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-annotation-deselection' into keyboard-event-selection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0e2f5cf View commit details
    Browse the repository at this point in the history

  5. Added completion for the keyboard selection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0bdc419 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'recogito#136-fix-not-dismisssed-annotation-on-native-ra… 

    …nge-click' into keyboard-event-selection

# Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    dfb2e19 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Made popup appear on keydown

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    34b3585 View commit details
    Browse the repository at this point in the history

  2. Added closing of the popup on selection cleanup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3442d4b View commit details
    Browse the repository at this point in the history

  3. Added focusing on the popup content on pointerup event

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bf6ef6f View commit details
    Browse the repository at this point in the history

  4. Made the TextAnnotatorPopup handle the focus for the popup content

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9df1a89 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Added focus message supply

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b2b25c1 View commit details
    Browse the repository at this point in the history

  2. Added automatic focusing on the popup with the focus manager

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d56359c View commit details
    Browse the repository at this point in the history

  3. Removed unused ts-key-enum

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5e4944b View commit details
    Browse the repository at this point in the history

  4. Fixed arrow button not dismissing selection, when the focus isn't on … 

    …the container
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c8159a1 View commit details
    Browse the repository at this point in the history

  5. Disabled autofocus for the keyboard selection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4b6cbc2 View commit details
    Browse the repository at this point in the history

  6. Named useAnnotator result consistently

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fde29cc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'keyboard-popup-focus-handling' into keyboard-event-sele… 

    …ction

# Conflicts:
#	packages/text-annotator-react/src/TextAnnotatorPopup.tsx
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d1263ad View commit details
    Browse the repository at this point in the history

  8. Removed unused TextAnnotatorPopup props

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d6609a6 View commit details
    Browse the repository at this point in the history

  9. Made the popup non-modal

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e0bb05f View commit details
    Browse the repository at this point in the history

  10. Added caret position restoration upon closing the popup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9b2df10 View commit details
    Browse the repository at this point in the history

  11. Made the caret restored on the up-to-date position

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5653502 View commit details
    Browse the repository at this point in the history

  12. Removed unused ref propagation

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    22481b1 View commit details
    Browse the repository at this point in the history

  13. Added selection caret restoration hook

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b86b86d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Fixed jumping viewport on focus return

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a3b589c View commit details
    Browse the repository at this point in the history

  2. Made the caret restored on the selection range start

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fd6c07b View commit details
    Browse the repository at this point in the history

  3. Limited arrow listener only to the annotatable container

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    94b182f View commit details
    Browse the repository at this point in the history

  4. Added focusing on the content upon restoring the caret

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    66ede9f View commit details
    Browse the repository at this point in the history

  5. Added selection discard on focus leaving the popup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6afa6fe View commit details
    Browse the repository at this point in the history

  6. Added sr-only popup close message

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7b71687 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Typo fix

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    17a1606 View commit details
    Browse the repository at this point in the history

  2. Added popup rendering above the highlights

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8aeec59 View commit details
    Browse the repository at this point in the history

  3. Moved currentTarget cleanup into the pointerdown handler

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5014052 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1ac04d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Added annotation reference cleanup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8684a8a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Bumped floating-ui to ^0.26.23 

    # See - https://github.com/floating-ui/floating-ui/releases/tag/%40floating-ui%2Freact%400.26.23
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    74e8e13 View commit details
    Browse the repository at this point in the history

  2. Added focus-out reason listening

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e6f8540 View commit details
    Browse the repository at this point in the history

  3. Removed duplicated currentTarget cleanup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    12da782 View commit details
    Browse the repository at this point in the history

  4. Added the whole selection range restoration upon popup dismissal

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9517a97 View commit details
    Browse the repository at this point in the history

  5. Removed the selection range restoration hook

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ea1fc24 View commit details
    Browse the repository at this point in the history

  6. Fixed processing of a collapsed selection on selectionchange event

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    356f72e View commit details
    Browse the repository at this point in the history

  7. Removed testing log

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3a57f75 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Added arrow movement handling on the body

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d0d14db View commit details
    Browse the repository at this point in the history

  2. Limited arrow handling to the container & body explicitly

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    fd74af8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'main' into fix-annotation-deselection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1883141 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	package-lock.json
#	packages/text-annotator-react/package.json
#	packages/text-annotator/package.json
#	packages/text-annotator/src/SelectionHandler.ts
#	packages/text-annotator/src/utils/index.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fcbfc8f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'recogito#136-fix-not-dismisssed-annotation-on-native-ra… 

    …nge-click' into keyboard-event-selection

# Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    247ef33 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Moved currentTarget reset back to the pointerup handler

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    690008f View commit details
    Browse the repository at this point in the history

  2. Added selectstart emulation when text is clicked

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ef3c620 View commit details
    Browse the repository at this point in the history

  3. Added existence check before explicit reselection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    38ad41d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-annotation-deselection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    be8478b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator-react/src/TextAnnotatorPopup.tsx
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2dcb13c View commit details
    Browse the repository at this point in the history

  6. Updated popup props

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    dcd8291 View commit details
    Browse the repository at this point in the history

  7. Limited emulation logic only to the pointer events

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1252404 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'fix-testing-component-popup-rendering' into keyboard-ev… 

    …ent-selection

# Conflicts:
#	packages/text-annotator-react/src/TextAnnotatorPopup.tsx
#	packages/text-annotator-react/test/App.tsx
#	packages/text-annotator-react/test/index.html
#	packages/text-annotator-react/test/tei/index.html
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    51a92c6 View commit details
    Browse the repository at this point in the history

  9. Added FC usage of the tei test popup

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b35904c View commit details
    Browse the repository at this point in the history

  10. Merge branch 'recogito#136-fix-not-dismisssed-annotation-on-native-ra… 

    …nge-click' into keyboard-event-selection

# Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9316a66 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'main' into fix-annotation-deselection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    166540e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
#	packages/text-annotator/src/TextAnnotator.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    90861b4 View commit details
    Browse the repository at this point in the history

  3. Re-hash

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1b9a5b1 View commit details
    Browse the repository at this point in the history

  4. Re-hash

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c6f71d3 View commit details
    Browse the repository at this point in the history

  5. Added pointerdown capturing on the document

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    694247d View commit details
    Browse the repository at this point in the history

  6. Added ignoring pointerdown on not-annotatable

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ed63ccd View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'main' into recogito#133-fix-not-dismissed-annotation-on… 

    …-outside-click
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    92e4156 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-annotation-deselection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1ce62a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator-react/test/App.tsx
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cbe374d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'recogito#133-fix-not-dismissed-annotation-on-outside-cl… 

    …ick' into keyboard-event-selection

# Conflicts:
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    43872e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'main' into recogito#133-fix-not-dismissed-annotation-on… 

    …-outside-click
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dc27158 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-annotation-deselection

    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5d7ddcc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-annotation-deselection' into keyboard-event-selection 

    # Conflicts:
#	packages/text-annotator-react/src/TextAnnotatorPopup.tsx
#	packages/text-annotator/src/SelectionHandler.ts
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fdb047a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'recogito#133-fix-not-dismissed-annotation-on-outside-cl… 

    …ick' into keyboard-event-selection
    @oleksandr-danylchenko
    oleksandr-danylchenko committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d18ff7b View commit details
    Browse the repository at this point in the history