Initialize nil maps before setting key #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, about half of the `Add*()` methods that set a value in a map checked if the map was nil before setting a field. Now they all do. Signed-off-by: Scott Andrews <scott@andrews.me>
|
cc @mamachanko |
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 10.58% 10.45% -0.13%
==========================================
Files 64 64
Lines 3024 3060 +36
==========================================
Hits 320 320
- Misses 2702 2738 +36
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mamachanko
approved these changes
Aug 31, 2022
| @@ -41,6 +41,9 @@ type _ = corev1.LimitRangeItem | |||
|
|
|||
| func (d *LimitRangeItemDie) AddMax(name corev1.ResourceName, quantity resource.Quantity) *LimitRangeItemDie { | |||
| return d.DieStamp(func(r *corev1.LimitRangeItem) { | |||
| if r.Max == nil { | |||
There was a problem hiding this comment.
I approve this change in particular.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, about half of the
Add*()methods that set a value in a mapchecked if the map was nil before setting a field. Now they all do.
Resolves #66
Signed-off-by: Scott Andrews scott@andrews.me