-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity as a core concept is missing properties
field.
#174
Comments
I also don't think we need the sentence after this: > Moreover, for each property it contains a set of associated property values, possibly empty.
To me this is intentional. The fields that are listed in this section are the "core" fields that can be serialized easily in most places where an entity is represented. If we were to include all of the property values in each entity every time we serialize it, it would make for quite big payloads. I think the |
Perhaps, let's see what others think. I don't quite understand what you mean, why would you want to include property "values" instead of "fields", or at least the properties field like I've done on the PR to acknowledge its relationship early on with the concept of an Entity? To me "properties" is almost a "core" field, I think, when we talk about the concept of Entities from a semantic perspective which is what we're doing in section 2 overall; explaining the 3 basic concepts of Entities, Types, Properties. |
…ty-concept Fix #174 Improve grammar in Entity concept
Maybe I'm missing something but when reading section 2. Core Concepts, we didn't list the field
properties
.Yet later on in section 2.3 Properties, we say:
Luckily, our schema examples however show the
"properties"
field in the Suggest Entities Response Schema.Anyways, not a huge deal, but we need to add the
properties
field to the concept Entity in section 2.1 to be descriptively complete.The text was updated successfully, but these errors were encountered: