Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elementId to html widgets in introduction vignette #34

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Aug 14, 2018

Currently, the id attributes for the vis and map elements of the introduction look something like this: htmlwidget-080aed570e3f25a577b3, making the URL to link to these elements a bit unwieldy:

https://www.repidemicsconsortium.org/epiflows/articles/introduction.html#htmlwidget-080aed570e3f25a577b3

This PR adds explicit id attributes so that linking is a bit easier:

https://www.repidemicsconsortium.org/epiflows/articles/introduction.html#introduction-epiflows-vis

@cosi1
Copy link
Collaborator

cosi1 commented Aug 14, 2018

@zkamvar Btw. did you downgrade some packages on purpose, or simply compiled the documentation on another machine? ;-)

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          24       24           
  Lines         447      447           
=======================================
  Hits          445      445           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b246d...b2352ab. Read the comment docs.

@zkamvar
Copy link
Member Author

zkamvar commented Aug 14, 2018

Ah! I compiled on a different machine, which caused the manual update to leaflet to revert 🤦‍.

That being said, as pointed out in the conversation over at leaflet (rstudio/leaflet#575), it really isn't much of an issue, but does cause warning bubbles to pop up for the maintainers (i.e. you and me).

@cosi1
Copy link
Collaborator

cosi1 commented Aug 14, 2018

Sure :D

@zkamvar zkamvar merged commit c58c51b into master Aug 14, 2018
@zkamvar zkamvar deleted the update-website-2 branch August 14, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants