Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep GHA Fix] The GitHub Actions run failed with... #209

Open
wants to merge 2 commits into
base: sweep/fix-sendinblue-docs-url_1
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Jan 4, 2024

Description

This pull request includes the following changes:

  • In packages/node-dev/src/Build.ts:
    • Added error handling when creating a custom tsconfig file.
  • In packages/nodes-base/nodes/SendInBlue/SendInBlue.node.ts:
    • Updated the documentationUrl property in the INodeTypeDescription object.
  • In scripts/validate-docs-links.js:
    • Modified the validateUrl function to handle different status codes.
    • Updated the checkLinks function to handle different status codes.

Summary

  • Added error handling when creating a custom tsconfig file in packages/node-dev/src/Build.ts.
  • Updated the documentationUrl property in the INodeTypeDescription object in packages/nodes-base/nodes/SendInBlue/SendInBlue.node.ts.
  • Modified the validateUrl function and the checkLinks function in scripts/validate-docs-links.js to handle different status codes.

Copy link

height bot commented Jan 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Author

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

github-actions bot commented Jan 4, 2024

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

Copy link
Author

sweep-ai bot commented Jan 4, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run n8n-io/validate-n8n-pull-request-title@v1.1
yielded the following error:
##[error]PR title does not match PR title convention: type: subject or type(scope): subject. For `type`, use `type:` or `type(scope):`, where `type` is one of `feat`, `fix`, `perf`, `test`, `docs`, `refactor`, `build`, `ci`. If present, `scope` must be one of `API`, `core`, `editor` or `<displayName> Node`. For the subject, mind the whitespace, start with lowercase and omit final period

Here are the logs:
PR title failed validation
validate-n8n-pull-request-title failed to run

[!CAUTION]

An error has occurred: 422 {"message": "Validation Failed", "errors": [{"resource": "PullRequest", "code": "custom", "message": "No commits between sweep/sweep_gha_fix_the_github_actions_run_fai_3 and sweep/sweep_gha_fix_the_github_actions_run_fai_4"}], "documentation_url": "https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} (tracking ID: b024809e54)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants