[ci-review] Rector Rectify

rectorphp · May 17, 2021 · 25df75b · 25df75b
1 parent 37219bf
commit 25df75b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/Console/Command/ShowCommand.php b/src/Console/Command/ShowCommand.php
@@ -38,7 +38,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
     private function reportLoadedRectors(): void
     {
-        $rectors = array_filter($this->rectors, function (RectorInterface $rector) {
+        $rectors = array_filter($this->rectors, function (RectorInterface $rector): bool {
             return ! $rector instanceof PostRectorInterface;
         });
 

diff --git a/src/DependencyInjection/CompilerPass/DeprecationWarningCompilerPass.php b/src/DependencyInjection/CompilerPass/DeprecationWarningCompilerPass.php
@@ -19,14 +19,15 @@ final class DeprecationWarningCompilerPass implements CompilerPassInterface
 
     public function process(ContainerBuilder $containerBuilder): void
     {
-        $parametersBag = $containerBuilder->getParameterBag();
+        $parameterBag = $containerBuilder->getParameterBag();
 
         foreach (self::DEPRECATED_PARAMETERS as $parameter => $message) {
-            if (! $parametersBag->has($parameter)) {
+            $parameterBagHas = $parameterBag->has($parameter);
+            if (! $parameterBagHas) {
                 continue;
             }
 
-            $setsParameters = $parametersBag->get($parameter);
+            $setsParameters = $parameterBag->get($parameter);
             if ($setsParameters === []) {
                 continue;
             }

diff --git a/src/NodeManipulator/ClassMethodAssignManipulator.php b/src/NodeManipulator/ClassMethodAssignManipulator.php
@@ -36,7 +36,7 @@ final class ClassMethodAssignManipulator
     /**
      * @var array<string, string[]>
      */
-    private $alreadyAddedClassMethodNames = [];
+    private array $alreadyAddedClassMethodNames = [];
 
     public function __construct(
         private BetterNodeFinder $betterNodeFinder,