[CodeQuality] Handle with assign missing parentheses on ExplicitBoolC…

…ompareRector (#6668)

rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/with_assign.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\ExplicitBoolCompareRector\Fixture;
+
+final class WithAssign
+{
+    private function getExpiredAt(): \Datetime|null
+    {
+        return null;
+    }
+
+    public function run(string $item)
+    {
+        if ($expired = $this->getExpiredAt()) {
+            echo $expired->format('Ymd');
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\ExplicitBoolCompareRector\Fixture;
+
+final class WithAssign
+{
+    private function getExpiredAt(): \Datetime|null
+    {
+        return null;
+    }
+
+    public function run(string $item)
+    {
+        if (($expired = $this->getExpiredAt()) !== null) {
+            echo $expired->format('Ymd');
+        }
+    }
+}
+
+?>

rules/CodeQuality/Rector/If_/ExplicitBoolCompareRector.php

@@ -28,6 +28,7 @@
 use PhpParser\Node\Stmt\If_;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\TypeAnalyzer\ArrayTypeAnalyzer;
 use Rector\NodeTypeResolver\TypeAnalyzer\StringTypeAnalyzer;
 use Rector\PhpParser\Node\Value\ValueResolver;
@@ -129,6 +130,10 @@ public function refactor(Node $node): null|array|Node
             return [$expression, $node];
         }
 
+        if ($node->cond instanceof Assign) {
+            $binaryOp->left->setAttribute(AttributeKey::WRAPPED_IN_PARENTHESES, true);
+        }
+
         $node->cond = $binaryOp;
 
         return $node;