[TypeDeclaration] Skip variadic on AddParamTypeBasedOnPHPUnitDataProv…

…iderRector (#6150) * [TypeDeclaration] Skip variadic on AddParamTypeBasedOnPHPUnitDataProviderRector * [TypeDeclaration] Skip variadic on AddParamTypeBasedOnPHPUnitDataProviderRector
rectorphp · Jul 15, 2024 · d6de24c · d6de24c
1 parent 07a3bdc
commit d6de24c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/...or/ClassMethod/AddParamTypeBasedOnPHPUnitDataProviderRector/Fixture/skip_variadic.php.inc b/...or/ClassMethod/AddParamTypeBasedOnPHPUnitDataProviderRector/Fixture/skip_variadic.php.inc
@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeBasedOnPHPUnitDataProviderRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipVariadic extends TestCase
+{
+    /**
+     * @dataProvider dataDummy
+     */
+    public function testDummy(...$args): void {
+    	self::assertIsArray($args);
+    }
+
+    public function dataDummy(): array {
+        return [
+        	'case'=> [4, 'arg']           // <-- int + string
+        ];
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeBasedOnPHPUnitDataProviderRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeBasedOnPHPUnitDataProviderRector.php
@@ -339,6 +339,10 @@ private function refactorClassMethod(ClassMethod $classMethod, Class_ $class, ar
                 continue;
             }
 
+            if ($param->variadic) {
+                continue;
+            }
+
             $paramTypes = [];
             foreach ($dataProviderNodes as $dataProviderNode) {
                 $paramTypes[] = $this->inferParam($class, $parameterPosition, $dataProviderNode);