New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php83] add string type to concat constant #5516

Merged

TomasVotruba merged 1 commit into rectorphp:main from jdohuutin:main

Jan 29, 2024

Contributor

jdohuutin commented Jan 29, 2024 •

edited

Loading

This PR update the rule AddTypeToConstRector to set string type for Concat expression.

(assuming that a Concat expression is always a string)


          [Php83] add string type to concat constant

b59cf87

jdohuutin requested a review from TomasVotruba as a code owner

January 29, 2024 15:35

Member

TomasVotruba commented Jan 29, 2024

Looks good, thank you

TomasVotruba merged commit 52398c8 into rectorphp:main

39 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet