Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip ArrayKeysAndInArrayToArrayKeyExistsRector on keys variable used #57

Merged
merged 2 commits into from
May 17, 2021
Merged

[CodeQuality] Skip ArrayKeysAndInArrayToArrayKeyExistsRector on keys variable used #57

merged 2 commits into from
May 17, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

/cc @HenkPoley

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 2bc6ba8 into main May 17, 2021
@TomasVotruba TomasVotruba deleted the fix-6424 branch May 17, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayKeysAndInArrayToArrayKeyExistsRector should not apply if $keys is used before in_array(.., $keys, ..)
2 participants
@samsonasik @TomasVotruba