Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticTypeMapper] Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (take 3) #6420

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

samsonasik
Copy link
Member

Cherry-pick from #6415

this special service to cover phpstan notice:

  src/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php:59
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------
  - '#Doing instanceof PHPStan\\Type\\TypeWithClassName is error\-prone and deprecated\. Use Type\:\:getObjectClassNames\(\) or Type\:\:getObjectClassReflections\(\) instead#'
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------

if it approved, I can use in other instanceof check. Use special service to ease replace when there is regression and possibly multiple values usage

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit bcfb598 into main Nov 12, 2024
36 checks passed
@TomasVotruba TomasVotruba deleted the add-class-name-from-object-type branch November 12, 2024 10:15
@samsonasik samsonasik changed the title [StaticTypeMapper] Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks [StaticTypeMapper] Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (take 3) Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants