Fix RemoveDoubleAssignRector in case of method call #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-double-assign-mix
branch
from
51df0d0 to
8931c79
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-double-assign-mix
branch
from
8931c79 to
3b4eb07
Compare
samsonasik
reviewed
Nov 16, 2024
| @@ -116,6 +103,11 @@ public function refactor(Node $node): ?Node | |||
| continue; | |||
| } | |||
|
|
|||
| // next stmts can have side effect as well | |||
| if ($nextAssign->expr instanceof MethodCall) { | |||
There was a problem hiding this comment.
I think this needs more specific check, eg:
Suggested change
| if ($nextAssign->expr instanceof MethodCall) { | |
| if (($nextAssign->var instanceof PropertyFetch || $nextAssign->var instanceof StaticPropertyFetch) && $nextAssign->expr instanceof MethodCall) { |
like in line 111, I will create new PR for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.