New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Type->getIterableValueType() over ArrayType->getItemType() #6479

Merged

samsonasik merged 1 commit into rectorphp:main from staabm:fix4

Nov 23, 2024

Contributor

staabm commented Nov 23, 2024 •

edited

Loading

less risky first step which does not involve changing instanceof *Type checks.

relying on Type-interface will ease using Type instead of deprecated instanceof *Type conditions


          Use Type->getIterableValueType() over ArrayType-> getItemType()

a108ad9

staabm mentioned this pull request

Utilize PHPStan Type interface in TypeNormalizer #6478

Closed

staabm marked this pull request as ready for review

November 23, 2024 09:16

Member

samsonasik commented Nov 23, 2024

@staabm ok, let's give it a try ;), thank you

samsonasik merged commit 391ba2a into rectorphp:main

36 checks passed

staabm deleted the fix4 branch

November 23, 2024 09:23

staabm mentioned this pull request

Use Type->getIterableKeyType() over ArrayType->getKeyType() #6480

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet