New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Use Param->isPromoted() over param->flags !== 0 check on promotion property check #6646

Merged

samsonasik merged 2 commits into main from is-promoted

Jan 5, 2025

Member

samsonasik commented Jan 5, 2025 •

edited

Loading

Using ->isPromoted() cover !==0 and property hook on php 8.4, also easier to verify instead of remember what !==0 means.

see https://github.com/nikic/PHP-Parser/blob/7d3039c37823003d576247868fe755f3d7ec70b8/lib/PhpParser/Node/Param.php#L67-L73

samsonasik added 2 commits

January 5, 2025 11:02


          use Param->isPromoted() over param->flags !== 0 check on promotion pr…

a384475

…operty check


          more check

acf097b

Member Author

samsonasik commented Jan 5, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

samsonasik merged commit 8ed98c1 into main

41 checks passed

samsonasik deleted the is-promoted branch

January 5, 2025 04:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet