Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withImportNames issue #8979

Closed
JapMul opened this issue Jan 16, 2025 · 1 comment · Fixed by rectorphp/rector-src#6672
Closed

withImportNames issue #8979

JapMul opened this issue Jan 16, 2025 · 1 comment · Fixed by rectorphp/rector-src#6672
Assignees
@samsonasik
Labels
bug

Comments

@JapMul
Copy link

JapMul commented Jan 16, 2025

Question

This might be intended behavior, but I'm not sure why it is happening like this. The following refactor occurred in our codebase and actually broke the functionality. We have our own helpers namespace with some helper classes. The Yii2 framework also comes with helper classes located in yii\helpers\. Why isn't \yii\helpers\VarDumper moved to use yii\helpers\VarDumper in this case?

image

https://getrector.com/demo/cb0f6267-ee7e-436f-813d-aba9b1162e53
@JapMul JapMul changed the title Namespace mismatch withImportNames issue Jan 16, 2025
@samsonasik
Copy link
Member

Just quick look, it seems a bug, I will look at it when I am back to PC

@samsonasik samsonasik self-assigned this Jan 16, 2025
@samsonasik samsonasik added the bug label Jan 16, 2025
@samsonasik samsonasik mentioned this issue Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsonasik samsonasik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AutoImport] Handle FQCN with sub namespace rectorphp/rector-src
2 participants
@samsonasik @JapMul