Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoImport] Handle FQCN with sub namespace #6672

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[AutoImport] Handle FQCN with sub namespace #6672

merged 2 commits into from
Jan 16, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @JapMul

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 7a6c4c5 into main Jan 16, 2025
41 checks passed
@samsonasik samsonasik deleted the use-fqcn branch January 16, 2025 12:03
@samsonasik
Copy link
Member Author

inner sub namespace seems need to be covered, see https://getrector.com/demo/d0182308-a4a1-4a5f-9061-bfe83ea2a4f4

I will look more into it

@samsonasik
Copy link
Member Author

#6679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withImportNames issue
1 participant
@samsonasik