Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bugs in the Pager #106

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fixing bugs in the Pager #106

merged 1 commit into from
Apr 22, 2020

Conversation

douglasmiller
Copy link
Contributor

Resolves #105

There are two bugs that are fixed here.

  1. The error handling code was silently failing when a non-2XX response contained a Content-Type: application/json header but no body.
  2. The Pager class was not sending the original params if the count() method was called prior to iteration.

bhelx
bhelx reviewed Apr 21, 2020
View reviewed changes
lib/recurly/Pager.js Outdated Show resolved Hide resolved
@douglasmiller douglasmiller force-pushed the pager-bugs branch 3 times, most recently from 5bdfae7 to 5b86c2f Compare April 21, 2020 20:48
bhelx
bhelx approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit adefe7e into master Apr 22, 2020
@bhelx bhelx deleted the pager-bugs branch April 22, 2020 01:02
@bhelx bhelx mentioned this pull request Apr 22, 2020
Closed
bhelx added a commit that referenced this pull request May 1, 2020
@bhelx
Release 3.7.0
3feef46 
# Changelog

## [Unreleased](https://github.com/recurly/recurly-client-node/tree/HEAD)

[Full Changelog](3.6.0...HEAD)

**Implemented enhancements:**

- Add recordExternalTransaction operation [\#109](#109) ([bhelx](https://github.com/bhelx))

**Fixed bugs:**

- Clarification listInvoices on params; limit does not seem to be working [\#105](#105)
- Fixing bugs in the Pager [\#106](#106) ([douglasmiller](https://github.com/douglasmiller))
@bhelx bhelx mentioned this pull request May 1, 2020
Merged
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
bug V3 v2019-10-10 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification listInvoices on params; limit does not seem to be working
3 participants
@douglasmiller @bhelx @joannasese