Adding hierarchical errors #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasmiller
force-pushed
the
better-errors
branch
from
f511c63
to
ef88e20
Compare
douglasmiller
force-pushed
the
better-errors
branch
from
ef88e20
to
eff21b4
Compare
bhelx
approved these changes
Jul 15, 2020
douglasmiller
added a commit
that referenced
this pull request
Jul 31, 2020
# Changelog ## [Unreleased](https://github.com/recurly/recurly-client-node/tree/HEAD) [Full Changelog](3.10.0...HEAD) **Implemented enhancements:** - Add request types to TS definitions [\#134](#134) ([bhelx](https://github.com/bhelx)) - Adding hierarchical errors [\#132](#132) ([douglasmiller](https://github.com/douglasmiller)) **Merged pull requests:** - Latest Changes for 2019-10-10 \(usage, measured units, etc\) [\#138](#138) ([bhelx](https://github.com/bhelx)) - Running npm audit fix [\#133](#133) ([bhelx](https://github.com/bhelx)) - Mon Jul 6 14:52:04 UTC 2020 Upgrade API version v2019-10-10 [\#130](#130) ([douglasmiller](https://github.com/douglasmiller))
Merged
douglasmiller
added a commit
that referenced
this pull request
Jul 31, 2020
[Full Changelog](3.10.0...HEAD) **Implemented enhancements:** - Add request types to TS definitions [\#134](#134) ([bhelx](https://github.com/bhelx)) - Adding hierarchical errors [\#132](#132) ([douglasmiller](https://github.com/douglasmiller)) **Merged pull requests:** - Latest Changes for 2019-10-10 \(usage, measured units, etc\) [\#138](#138) ([bhelx](https://github.com/bhelx)) - Running npm audit fix [\#133](#133) ([bhelx](https://github.com/bhelx)) - Mon Jul 6 14:52:04 UTC 2020 Upgrade API version v2019-10-10 [\#130](#130) ([douglasmiller](https://github.com/douglasmiller))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking update to error classes to give them a hierarchical structure. This will facilitate differentiating between a
ClientErrorand aServerErrorfor example.New error classes have also been added to be parent classes for some existing errors (e.g.
ForbiddenErroris a new class and bothInvalidApiKeyErrorandInvalidPermissionsErrorextend it)