Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes response header references case insensitive #149

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

dbrudner
Copy link
Contributor

@dbrudner dbrudner commented Oct 5, 2020

All response headers previously were being accessed through lowercase values with the exception of Recurly-Sunset-Date and Recurly-Deprecated

Pager/list methods are working fine with the current release. The update here is for the purpose of fixing the two above headers and future-proofing.

@dbrudner dbrudner added the WIP Work In Progress label Oct 5, 2020
@dbrudner dbrudner removed the WIP Work In Progress label Oct 5, 2020
Copy link
Contributor

@douglasmiller douglasmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@douglasmiller douglasmiller merged commit b776402 into master Oct 6, 2020
douglasmiller added a commit that referenced this pull request Oct 8, 2020
# Changelog

## [Unreleased](https://github.com/recurly/recurly-client-node/tree/HEAD)

[Full Changelog](3.14.0...HEAD)

**Fixed bugs:**

- Makes response header references case insensitive [\#149](#149) ([dbrudner](https://github.com/dbrudner))
@douglasmiller douglasmiller mentioned this pull request Oct 8, 2020
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 12, 2021
@douglasmiller douglasmiller deleted the normalize-response-headers branch September 1, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V3 v2019-10-10 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants