Update method parameter 'params' to 'options' and related doc comments #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasmiller
added a commit
that referenced
this pull request
Apr 20, 2020
# Changelog ## [Unreleased](https://github.com/recurly/recurly-client-node/tree/HEAD) [Full Changelog](3.5.1...HEAD) **Implemented enhancements:** - Tue Apr 14 20:25:06 UTC 2020 Upgrade API version v2019-10-10 [\#103](#103) ([bhelx](https://github.com/bhelx)) - Validating options passed to \_makeRequest [\#101](#101) ([douglasmiller](https://github.com/douglasmiller)) **Merged pull requests:** - Included the to-be released changes in the changelog [\#102](#102) ([douglasmiller](https://github.com/douglasmiller)) - Remove docs from tracking and use github actions [\#100](#100) ([bhelx](https://github.com/bhelx)) - Update method parameter 'params' to 'options' and related doc comments [\#98](#98) ([douglasmiller](https://github.com/douglasmiller))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the method parameter
paramstooptionsto more accurate reflect what the intent of the parameter is. Also updates the incorrect doc comments to better clarify thatoptions.paramsmust be an object with individual url parameter keys within.Resolves #97