Merge pull request #241 from recurly/less-getRequiredAttributes

Provide default getWriteableAttributes()
recurly · Jun 22, 2016 · 5805e80 · 5805e80
2 parents b896a78 + 947454d
commit 5805e80
Show file tree

Hide file tree

Showing 16 changed files with 4 additions and 46 deletions.
diff --git a/Tests/Recurly/Pager_Test.php b/Tests/Recurly/Pager_Test.php
@@ -16,7 +16,6 @@ public function _loadFrom($uri, $params = null) {
 class Mock_Item extends Recurly_Resource {
   protected function getNodeName()            { return 'mock'; }
   protected function getWriteableAttributes() { return array(); }
-  protected function getRequiredAttributes()  { return array(); }
 }
 Recurly_Resource::$class_map['mock'] = 'Mock_Item';
 

diff --git a/lib/recurly/addon.php b/lib/recurly/addon.php
@@ -51,9 +51,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Addon::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Addon::init();
diff --git a/lib/recurly/address.php b/lib/recurly/address.php
@@ -19,10 +19,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Address::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
-
 }
 
 Recurly_Address::init();
diff --git a/lib/recurly/adjustment.php b/lib/recurly/adjustment.php
@@ -69,9 +69,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Adjustment::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Adjustment::init();
diff --git a/lib/recurly/billing_info.php b/lib/recurly/billing_info.php
@@ -52,9 +52,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_BillingInfo::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_BillingInfo::init();
diff --git a/lib/recurly/coupon.php b/lib/recurly/coupon.php
@@ -124,9 +124,6 @@ protected function getWriteableAttributes() {
   protected function getUpdatableAttributes() {
     return Recurly_Coupon::$_updatableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Coupon::init();
diff --git a/lib/recurly/invoice.php b/lib/recurly/invoice.php
@@ -123,9 +123,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Invoice::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
   protected function uri() {
     $invoiceNumberWithPrefix = $this->invoiceNumberWithPrefix();
     if (!empty($this->_href))

diff --git a/lib/recurly/measured_unit.php b/lib/recurly/measured_unit.php
@@ -35,9 +35,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_MeasuredUnit::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_MeasuredUnit::init();
diff --git a/lib/recurly/note.php b/lib/recurly/note.php
@@ -9,8 +9,4 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
    return array();
   }
-
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
diff --git a/lib/recurly/plan.php b/lib/recurly/plan.php
@@ -57,9 +57,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Plan::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Plan::init();
diff --git a/lib/recurly/resource.php b/lib/recurly/resource.php
@@ -8,7 +8,10 @@ abstract class Recurly_Resource extends Recurly_Base
 
   abstract protected function getNodeName();
   abstract protected function getWriteableAttributes();
-  abstract protected function getRequiredAttributes();
+  protected function getRequiredAttributes()
+  {
+    return array();
+  }
 
   public function __construct($href = null, $client = null)
   {

diff --git a/lib/recurly/subscription.php b/lib/recurly/subscription.php
@@ -134,9 +134,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Subscription::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Subscription::init();
diff --git a/lib/recurly/subscription_addon.php b/lib/recurly/subscription_addon.php
@@ -22,9 +22,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_SubscriptionAddOn::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 
   protected function populateXmlDoc(&$doc, &$node, &$obj, $nested = false) {
     $addonNode = $node->appendChild($doc->createElement($this->getNodeName()));

diff --git a/lib/recurly/tax_detail.php b/lib/recurly/tax_detail.php
@@ -7,7 +7,4 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return array();
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
diff --git a/lib/recurly/transaction.php b/lib/recurly/transaction.php
@@ -56,9 +56,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Transaction::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Transaction::init();
diff --git a/lib/recurly/usage.php b/lib/recurly/usage.php
@@ -52,9 +52,6 @@ protected function getNodeName() {
   protected function getWriteableAttributes() {
     return Recurly_Usage::$_writeableAttributes;
   }
-  protected function getRequiredAttributes() {
-    return array();
-  }
 }
 
 Recurly_Usage::init();