Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurly_Invoice::getPdf does not take invoice_number_prefix into account #143

Closed
jaanttil opened this issue Mar 20, 2015 · 1 comment · Fixed by #155
Closed

Recurly_Invoice::getPdf does not take invoice_number_prefix into account #143

jaanttil opened this issue Mar 20, 2015 · 1 comment · Fixed by #155
Labels
V2 V2 Client

Comments

@jaanttil
Copy link

Recurly_Invoice::getPdf does not work for invoices where invoice_number_prefix exist. The workaround is to use getInvoicePdf with the following argument: $invoice->invoice_number_prefix . $invoice->invoice_number

@drewish
Copy link

drewish commented Mar 20, 2015

Ah yeah seems like we over looked that. I think we can just change it to:

public function getPdf($locale = null) {
  return Recurly_Invoice::getInvoicePdf($this->invoiceNumberWithPrefix(), $locale, $this->_client);
}

And have change the docs for Recurly_Invoice::getInvoicePdf to specify that the prefix be included with the invoice number.

austinheap added a commit that referenced this issue Mar 24, 2015
austinheap added a commit that referenced this issue Apr 28, 2015
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants