Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurly_Transaction::get should return original_transaction_id for refunds #216

Closed
phpdave opened this issue Mar 16, 2016 · 7 comments
Closed
Labels
V2 V2 Client

Comments

@phpdave
Copy link

phpdave commented Mar 16, 2016

Problem

I don't see a way to tie a refund transaction back to the original transaction via the PHP client

Suggested Solution

Recurly_Transaction::get($uuid) should have an additional field returned that's called original_transaction_id for refund transactions

and/or

Successful Refund webhook notification xml ( Recurly_PushNotification ) should have the original_transaction_id

References

From the exports overview doc:
original_transaction_id - For refunds, this field identifies the transaction being refunded.
https://docs.recurly.com/docs/export-overview

@drewish
Copy link

drewish commented Mar 16, 2016

Yeah, that value is currently not returned by the API in the transaction response so there's nothing for the PHP client to return.

@phpdave
Copy link
Author

phpdave commented Mar 16, 2016

@drewish thanks for the quick reply.

How do I make a request to Recurly for them to make an API change that would add original_transaction_id field to the transaction response?

@drewish
Copy link

drewish commented Mar 28, 2016

@phpdave hey sorry for the silence, trying to get the API change queued up since it would be a nice addition.

@drewish
Copy link

drewish commented Apr 12, 2016

Just an update that we've got this on our next sprint plan so we should have something out in a couple of weeks. I appreciate your patience.

@drewish
Copy link

drewish commented Apr 22, 2016

@phpdave the original transaction id should be coming back in the API responses starting on Wednesday. Changes to the client will follow.

@phpdave
Copy link
Author

phpdave commented Apr 27, 2016

Great can't wait for it! Thanks for your help in getting this implemented.

@drewish
Copy link

drewish commented May 2, 2016

So had to push this back a bit. Turns out it broke the ruby client so we had to revert the change. It'll come back in a new minor version of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

No branches or pull requests

3 participants