Hydrating a Resource node object doesn't transfer client instance from Recurly_Pager

[cyruscollier]

During a singular resource hydration Recurly_Base::__parseResponseToNewObject() is called, which passes the client instance to the newly created resource object. However, when a Recurly_Pager subclass like Recurly_SubscriptionList hydrates all of its nodes and calls Recurly_Base::__createNodeObject(), that method does NOT pass the client instance to the each newly created resource objects. This means if a subclassed or mocked Recurly_Client class is used as the client in Recurly_SubscriptionList, the resulting node objects cannot be used directly with the same expected client behavior.

[drewish]

Interesting... so seems like __parseXmlToObject should either be assigning _client or __createNodeObject should take client as a parameter and assign it.

Do you have any test code you were using that demonstrates the problem that I could use to build a unit test off of?

[cyruscollier]

I can do one better than that! Here's a full unit test demonstrating the problem and a patch that solves it. You'll see when this test runs that we get the error Recurly_UnauthorizedError: Your API Key is not authorized to connect to Recurly., which means the test isn't using the Recurly_MockClient when trying to reactivate on a subscription node. I've included a patch for Recurly_Base which passes the client down to all of the child nodes.

SubscriptionNode_Test.php.txt
base.php.diff.txt

[cyruscollier]

Any updates/thoughts on this?

[drewish]

hey sorry! i want to get this into the next release. would you be offended if i redo that spec?

[cyruscollier]

Are you referring to the unit test I wrote? Yeah, do whatever you want with it - it's just for demonstrating the issue.